nandakumar131 commented on code in PR #3885: URL: https://github.com/apache/ozone/pull/3885#discussion_r1009761163
########## hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/ManagedSSTFileReader.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ozone.rocksdb.util; + +import org.rocksdb.Options; +import org.rocksdb.ReadOptions; +import org.rocksdb.RocksDBException; +import org.rocksdb.SstFileReader; +import org.rocksdb.SstFileReaderIterator; + +import java.io.Closeable; +import java.util.Collection; +import java.util.Iterator; +import java.util.NoSuchElementException; +import java.util.Spliterator; +import java.util.Spliterators; +import java.util.stream.Stream; +import java.util.stream.StreamSupport; + +public class ManagedSSTFileReader { + + private final Collection<String> sstFiles; + + public ManagedSSTFileReader(final Collection<String> sstFiles) { + this.sstFiles = sstFiles; + } + public Stream<String> getKeyStream() throws RocksDBException { + final OMSSTFileIterator iterator = new OMSSTFileIterator(sstFiles); + final Spliterator<String> spliterator = Spliterators + .spliteratorUnknownSize(iterator, 0); + return StreamSupport.stream(spliterator, false).onClose(iterator::close); + } + + public interface ClosableIterator<T> extends Iterator<T>, Closeable {} + + private static class OMSSTFileIterator implements ClosableIterator<String> { + + private final Iterator<String> fileNameIterator; + private final Options options; + private final ReadOptions readOptions; + private String currentFile; + private SstFileReader currentFileReader; + private SstFileReaderIterator currentFileIterator; + + private OMSSTFileIterator(Collection<String> files) throws RocksDBException { + // TODO: Check if default Options and ReadOptions is enough. + this.options = new Options(); + this.readOptions = new ReadOptions(); + this.fileNameIterator = files.iterator(); + moveToNextFile(); + } + + @Override + public boolean hasNext() { + try { + do { + if (currentFileIterator.isValid()) { + return true; + } + } while (moveToNextFile()); + } catch (RocksDBException e) { + return false; Review Comment: Added RuntimeException here for now. We have to catch and handle this exception in the caller, we should not crash OM process because of this exception. ########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java: ########## @@ -196,4 +203,40 @@ public static boolean isSnapshotKey(String[] keyParts) { return (keyParts.length > 1) && (keyParts[0].compareTo(OM_SNAPSHOT_INDICATOR) == 0); } -} + + public SnapshotDiffReport getSnapshotDiffReport(final String volume, + final String bucket, + final String fromSnapshot, + final String toSnapshot) + throws IOException { + // Validate fromSnapshot and toSnapshot + final SnapshotInfo fsInfo = getSnapshotInfo(volume, bucket, fromSnapshot); + final SnapshotInfo tsInfo = getSnapshotInfo(volume, bucket, toSnapshot); + verifySnapshotInfoForSnapDiff(fsInfo, tsInfo); + + final String fsKey = SnapshotInfo.getTableKey(volume, bucket, fromSnapshot); + final String tsKey = SnapshotInfo.getTableKey(volume, bucket, toSnapshot); + try { + final OmSnapshot fs = snapshotCache.get(fsKey); + final OmSnapshot ts = snapshotCache.get(tsKey); + return snapshotDiffManager.getSnapshotDiffReport(volume, bucket, fs, ts); + } catch (ExecutionException | RocksDBException e) { + throw new IOException(e.getCause()); + } + } + + private void verifySnapshotInfoForSnapDiff(final SnapshotInfo fromSnapshot, + final SnapshotInfo toSnapshot) + throws IOException { + if ((fromSnapshot.getSnapshotStatus() != SnapshotStatus.SNAPSHOT_ACTIVE) || + (toSnapshot.getSnapshotStatus() != SnapshotStatus.SNAPSHOT_ACTIVE)) { + // TODO: throw custom snapshot exception. + throw new IOException("Cannot generate snapshot diff for non-active " + + "snapshots."); + } + if (fromSnapshot.getCreationTime() > toSnapshot.getCreationTime()) { + throw new IOException("fromSnapshot should be older than to toSnapshot"); + } + } + + } Review Comment: Fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
