nandakumar131 commented on code in PR #3885: URL: https://github.com/apache/ozone/pull/3885#discussion_r1009761911
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffReport.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.snapshot; + +import java.util.Collections; +import java.util.List; + +public class SnapshotDiffReport { + + private final static String LINE_SEPARATOR = System.getProperty( + "line.separator", "\n"); + + /** + * Types of the difference, which include CREATE, MODIFY, DELETE, and RENAME. + * Each type has a label for representation: + * + CREATE + * M MODIFY + * - DELETE + * R RENAME + */ + public enum DiffType { + CREATE("+"), + MODIFY("M"), + DELETE("-"), + RENAME("R"); + + private final String label; + + DiffType(String label) { + this.label = label; + } + + public String getLabel() { + return label; + } + } + + public static class DiffReportEntry { + + /** + * The type of diff. + */ + private final DiffType type; + + /** + * Source File/Object path. + */ + private final String sourcePath; + + /** + * Destination File/Object path, if this is a re-name operation. + */ + private final String targetPath; + + private DiffReportEntry(final DiffType type, final String sourcePath, + final String targetPath) { + this.type = type; + this.sourcePath = sourcePath; + this.targetPath = targetPath; + } + + public static DiffReportEntry of(final DiffType type, + final String sourcePath) { + return of(type, sourcePath, null); + } + + public static DiffReportEntry of(final DiffType type, + final String sourcePath, + final String targetPath) { + return new DiffReportEntry(type, sourcePath, null); Review Comment: Fixed it. Thanks for catching this. ########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffReport.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.snapshot; + +import java.util.Collections; +import java.util.List; + +public class SnapshotDiffReport { + + private final static String LINE_SEPARATOR = System.getProperty( + "line.separator", "\n"); + + /** + * Types of the difference, which include CREATE, MODIFY, DELETE, and RENAME. + * Each type has a label for representation: + * + CREATE + * M MODIFY + * - DELETE + * R RENAME + */ + public enum DiffType { + CREATE("+"), + MODIFY("M"), + DELETE("-"), + RENAME("R"); + + private final String label; + + DiffType(String label) { + this.label = label; + } + + public String getLabel() { + return label; + } + } + + public static class DiffReportEntry { + + /** + * The type of diff. + */ + private final DiffType type; + + /** + * Source File/Object path. + */ + private final String sourcePath; + + /** + * Destination File/Object path, if this is a re-name operation. + */ + private final String targetPath; + + private DiffReportEntry(final DiffType type, final String sourcePath, + final String targetPath) { Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
