sodonnel commented on code in PR #3909:
URL: https://github.com/apache/ozone/pull/3909#discussion_r1010715598
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerReplicaPendingOps.java:
##########
@@ -108,7 +113,11 @@ public void scheduleDeleteReplica(ContainerID containerID,
*/
public boolean completeAddReplica(ContainerID containerID,
DatanodeDetails target, int replicaIndex) {
- return completeOp(ADD, containerID, target, replicaIndex);
+ boolean completed = completeOp(ADD, containerID, target, replicaIndex);
+ if (isMetricsNotNull() && completed && replicaIndex > 0) {
Review Comment:
Replicas with an index of zero are Ratis. Indexes greater than zero indicate
Erasure Coding replicas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
