sodonnel commented on code in PR #3909:
URL: https://github.com/apache/ozone/pull/3909#discussion_r1010751386
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/OverReplicatedProcessor.java:
##########
@@ -114,6 +114,9 @@ private void adjustPendingOps(ContainerID containerID,
SCMCommand<?> cmd,
DeleteContainerCommand rcc = (DeleteContainerCommand) cmd;
pendingOps.scheduleDeleteReplica(containerID, targetDatanode,
rcc.getReplicaIndex());
+ if (rcc.getReplicaIndex() > 0) {
Review Comment:
Inside the new RM code, we probably should have the `else
rcc.getReplicaIndex() == 0`. Now, only EC containers will land here, but when
we finally turn off the LegacyRM, Ratis containers will land here too. It would
make sense to be ready for that. That said, there will be more changes needed
to process Ratis containers in this code path, but not in this class I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
