sodonnel commented on code in PR #3909:
URL: https://github.com/apache/ozone/pull/3909#discussion_r1010753695
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/UnderReplicatedProcessor.java:
##########
@@ -119,12 +119,14 @@ private void adjustPendingOps(ContainerID containerID,
SCMCommand<?> cmd,
for (int i = 0; i < targetIndexes.length; i++) {
pendingOps.scheduleAddReplica(containerID, targets.get(i),
targetIndexes[i]);
+ replicationManager.getMetrics().incrEcReconstructionCmdsSentTotal();
}
} else if (cmd.getType() == StorageContainerDatanodeProtocolProtos
.SCMCommandProto.Type.replicateContainerCommand) {
ReplicateContainerCommand rcc = (ReplicateContainerCommand) cmd;
pendingOps.scheduleAddReplica(
containerID, targetDatanode, rcc.getReplicaIndex());
+ replicationManager.getMetrics().incrEcReplicationCmdsSentTotal();
Review Comment:
Might need to the `if replicaIndex > 0 ... else if replicaIndex == 0` logic
here, but not at line 122 above, as it is only EC code that can get there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
