JacksonYao287 commented on PR #3963: URL: https://github.com/apache/ozone/pull/3963#issuecomment-1320878217
@siddhantsangwan we have already have a [design doc](https://issues.apache.org/jira/secure/attachment/13026798/Container%20Move.pdf) for move , please take a look! the reasons for creating a new separate MoveManage are : 1 if we want to manager move operations, we need to be aware of inflight actions. before `ContainerReplicaPendingOps` is added, the inflight actions are managed by legacyRM. to be aware of these inflight actions, we have to create `MoveScheduler` inside it. but , that is not a good code structure. as we know that we are implementing the new ReplicaitonManager, and legacyRM will be dropped ultimately. so this is a good chance to add new separate MoveManage. 2 RM is a background service which will run periodically. so if a replication or deletion command in move operation is completed or expired, we can not take actions in time and have to wait until the RM begin running. this will delay the completion of move dramatically. now inflight actions are managed by `ContainerReplicaPendingOps`, and move manager can be notified of move related event in time , so that we can take actions as soon as possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
