sodonnel commented on code in PR #3963:
URL: https://github.com/apache/ozone/pull/3963#discussion_r1028221282
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java:
##########
@@ -183,6 +194,37 @@ public int getContainerStateCount(final LifeCycleState
state) {
return containerStateManager.getContainerIDs(state).size();
}
+ @Override
Review Comment:
There is already a getContainerReplicaCount method on ReplicationManager. I
am not sure we should add this to the ContainerManager interface, as its more
"replication" related that container replicas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
