kerneltime commented on PR #4005: URL: https://github.com/apache/ozone/pull/4005#issuecomment-1328586215
Putting my 2 cents in since this is a PR to refactor for better code quality. Should the `DefaultReplicationConfig` be `ReplicationConfig` and handle both EC and RATIS. The `ReplicationConfig` interface should only define the few interfaces that are implemented by individual replication types and move all the static methods to the new `ReplicationConfig`. This change seems fine but might be worth revisiting the Objects involved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
