swamirishi commented on code in PR #4005:
URL: https://github.com/apache/ozone/pull/4005#discussion_r1036363262
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/DefaultReplicationConfig.java:
##########
@@ -26,88 +26,53 @@
*/
public class DefaultReplicationConfig {
- private ReplicationType type;
- private ReplicationFactor factor;
- private ECReplicationConfig ecReplicationConfig;
-
- public DefaultReplicationConfig(ReplicationType type,
- ReplicationFactor factor) {
- this.type = type;
- this.factor = factor;
- this.ecReplicationConfig = null;
- }
+ private final ECReplicationConfig ecReplicationConfig;
+ private final ReplicationConfig replicationConfig;
public DefaultReplicationConfig(ReplicationConfig replicationConfig) {
- this.type =
- ReplicationType.fromProto(replicationConfig.getReplicationType());
+ this.replicationConfig = replicationConfig;
if (replicationConfig instanceof ECReplicationConfig) {
Review Comment:
nit: We could use getReplicationType() function instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
