sodonnel commented on code in PR #4006:
URL: https://github.com/apache/ozone/pull/4006#discussion_r1033470104
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java:
##########
@@ -57,6 +69,8 @@ public abstract class SCMCommonPlacementPolicy implements
PlacementPolicy {
private final ConfigurationSource conf;
private final boolean shouldRemovePeers;
+ private Function<ContainerReplica, RID> replicaIdentifierFunction;
Review Comment:
I don't think we need to make this generic for now. It causes a lot of
change through many other files to pass in this RID function in, and at the end
of the day, it is always `ContainerReplica.getReplicaIndex()`. Perhaps in the
future there will be something else, but I cannot think what that might be, so
I feel it is likely we will always just have `getReplicaIndex`, saying as the
rest of the code deals with containerReplicas only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
