sodonnel commented on code in PR #4006: URL: https://github.com/apache/ozone/pull/4006#discussion_r1033944973
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java: ########## @@ -69,7 +69,7 @@ private final ConfigurationSource conf; private final boolean shouldRemovePeers; - private Function<ContainerReplica, RID> replicaIdentifierFunction; + private Function<ContainerReplica, Integer> replicaIdentifierFunction; Review Comment: I don't think we need this function at all. The only function we ever have is `ContainerReplica::getReplicaIndex`, so lets just call `containerReplicaInstance.getReplicaIndex()` anytime we need it. There is no point in make this generic for the future as we probably won't need it, and we can always change it if we do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
