sodonnel commented on PR #4006: URL: https://github.com/apache/ozone/pull/4006#issuecomment-1330598804
I suggested leaving the parameters as they were for now, but the latest commit changed them anyway, and the other comments are not addressed. Lets add only the replicasToCopy method in this PR and save the replicasToRemove for another PR please. We also need to look at the algorithm used - I post a simplified version above I think will work, so we should check if that is the case as it appears to be simpler than the approach in this PR right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
