fapifta commented on code in PR #3982:
URL: https://github.com/apache/ozone/pull/3982#discussion_r1046110708
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DNCertificateClient.java:
##########
@@ -35,14 +51,26 @@ public class DNCertificateClient extends
DefaultCertificateClient {
LoggerFactory.getLogger(DNCertificateClient.class);
public static final String COMPONENT_NAME = "dn";
+ private final DatanodeDetails dn;
+ private SCMSecurityProtocolClientSideTranslatorPB secureScmClient;
- public DNCertificateClient(SecurityConfig securityConfig,
- String certSerialId) {
- super(securityConfig, LOG, certSerialId, COMPONENT_NAME);
+ public DNCertificateClient(OzoneConfiguration ozoneConfig,
Review Comment:
I am not sure what is the advantage of changing here to OzoneConfiguration
from SecurityConfig, can you share some reasoning for this change please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
