fapifta commented on code in PR #3982:
URL: https://github.com/apache/ozone/pull/3982#discussion_r1046113686
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java:
##########
@@ -110,28 +120,35 @@ public abstract class DefaultCertificateClient implements
CertificateClient {
private long localCrlId;
private String component;
private List<String> pemEncodedCACerts = null;
- private final Lock lock;
private KeyStoresFactory serverKeyStoresFactory;
private KeyStoresFactory clientKeyStoresFactory;
+ private AtomicBoolean isRenewing = new AtomicBoolean(false);
+ private AtomicBoolean isRenewed = new AtomicBoolean(false);
- DefaultCertificateClient(SecurityConfig securityConfig, Logger log,
+ DefaultCertificateClient(OzoneConfiguration conf, Logger log,
Review Comment:
I am not sure what is the advantage of changing here to OzoneConfiguration
from SecurityConfig, can you share some reasoning for this change please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
