fapifta commented on code in PR #3982:
URL: https://github.com/apache/ozone/pull/3982#discussion_r1050608418
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java:
##########
@@ -517,7 +548,7 @@ private boolean verifySignature(byte[] data, byte[]
signature,
*/
@Override
public CertificateSignRequest.Builder getCSRBuilder()
- throws CertificateException {
+ throws IOException {
Review Comment:
I think we should not change the exception type here, as we catch
IOExceptions, and wrap them into a CertificateException in the different
implementations as I saw, so I believe we should keep the signature here, note
that this affects a few caller methods as well, where the exception type marked
in the signature has changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
