adoroszlai commented on code in PR #4271:
URL: https://github.com/apache/ozone/pull/4271#discussion_r1105783993
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/StringUtils.java:
##########
@@ -105,12 +105,12 @@ public static String toStartupShutdownString(String
prefix, String... msg) {
}
public static void startupShutdownMessage(VersionInfo versionInfo,
- Class<?> clazz, String[] args, Logger log) {
+ Class<?> clazz, String[] args, Logger log, String conf) {
Review Comment:
I think it would be better to pass a `Map` here instead of a fully formatted
string. This would allow filtering some sensitive properties if needed, as
well as sorting the config properties alphabetically. (Currently order is
random, since `Properties` is just a `Hashtable`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
