errose28 commented on PR #4271:
URL: https://github.com/apache/ozone/pull/4271#issuecomment-1430591136
I don't think we should filter by tags or prefixes when printing the config.
I think we should just print the contents of whatever config object the
component has.
- I think this would show only options that the user has explicitly set,
which may be different than the defaults. I think this set of configs would be
more useful for debugging.
- We don't have to worry about missing config values in the log message due
to improper tagging now or for future values.
- It would show an accurate representation of the config the component has,
even if it does not read some of the values.
- This removes some assumptions about what components are supposed to
read vs. what they could potentially read, which could hinder debugging.
- Since this would usually be inspected for debugging purposes, users
can filter the configs they are looking for anyways.
Also +1 to Attila's suggestion of sorting the configs alphabetically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
