Galsza commented on code in PR #4231:
URL: https://github.com/apache/ozone/pull/4231#discussion_r1108597666
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java:
##########
@@ -601,58 +621,64 @@ public X509Certificate queryCertificate(String query) {
* Stores the Certificate for this client. Don't use this api to add trusted
* certificates of others.
*
- * @param pemEncodedCert - pem encoded X509 Certificate
- * @param force - override any existing file
+ * @param pemEncodedCert - pem encoded X509 Certificate
* @throws CertificateException - on Error.
- *
*/
@Override
- public void storeCertificate(String pemEncodedCert, boolean force)
+ public void storeCertificate(String pemEncodedCert)
throws CertificateException {
- this.storeCertificate(pemEncodedCert, force, false);
+ this.storeCertificate(pemEncodedCert, false);
}
/**
* Stores the Certificate for this client. Don't use this api to add trusted
* certificates of others.
*
- * @param pemEncodedCert - pem encoded X509 Certificate
- * @param force - override any existing file
- * @param caCert - Is CA certificate.
+ * @param pemEncodedCert - pem encoded X509 Certificate
+ * @param caCert - Is CA certificate.
* @throws CertificateException - on Error.
- *
*/
@Override
- public void storeCertificate(String pemEncodedCert, boolean force,
+ public void storeCertificate(String pemEncodedCert,
Review Comment:
Done. CAType is used now and it's also a unified enum from CertificateClient
and CertificateServer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
