Galsza commented on code in PR #4231:
URL: https://github.com/apache/ozone/pull/4231#discussion_r1108608728
##########
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/security/x509/CertificateClientTest.java:
##########
@@ -264,7 +279,8 @@ public void renewKey() throws Exception {
"CN=OzoneMaster", keyPair, 30, "SHA256withRSA");
keyPair = newKeyPair;
- x509Certificate = newCert;
+ CertificateFactory fact = CertificateFactory.getInstance("X.509");
Review Comment:
Done. Moved into CertificateCodec.
(In the end I chose BouncyCastle, it rearranges certificates to be in order
when creating a cert path and it is also able to read pem files seamlessly.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
