Galsza commented on code in PR #4231:
URL: https://github.com/apache/ozone/pull/4231#discussion_r1108614166
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/security/OMCertificateClient.java:
##########
@@ -162,26 +164,26 @@ public CertificateSignRequest.Builder
getCSRBuilder(KeyPair keyPair)
@Override
public String signAndStoreCertificate(PKCS10CertificationRequest request,
- Path certPath) throws CertificateException {
+ Path certificatePath) throws CertificateException {
try {
SCMGetCertResponseProto response = getScmSecureClient()
.getOMCertChain(omInfo, getEncodedString(request));
String pemEncodedCert = response.getX509Certificate();
CertificateCodec certCodec = new CertificateCodec(
- getSecurityConfig(), certPath);
+ getSecurityConfig(), certificatePath);
// Store SCM CA certificate.
if (response.hasX509CACertificate()) {
String pemEncodedRootCert = response.getX509CACertificate();
storeCertificate(pemEncodedRootCert,
- true, true, false, certCodec, false);
- storeCertificate(pemEncodedCert, true, false, false, certCodec, false);
+ CA, certCodec, false);
+ storeCertificate(pemEncodedCert, INTERMEDIATE, certCodec, false);
// Store Root CA certificate if available.
if (response.hasX509RootCACertificate()) {
storeCertificate(response.getX509RootCACertificate(),
- true, false, true, certCodec, false);
+ CertType.ROOT_CA, certCodec, false);
Review Comment:
They should now be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
