prashantpogde commented on code in PR #4280:
URL: https://github.com/apache/ozone/pull/4280#discussion_r1119358889
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -157,8 +162,23 @@ public static DBCheckpoint createOmSnapshotCheckpoint(
throws IOException {
RDBStore store = (RDBStore) omMetadataManager.getStore();
- final DBCheckpoint dbCheckpoint = store.getSnapshot(
- snapshotInfo.getCheckpointDirName());
+ final DBCheckpoint dbCheckpoint;
+
+ // Acquire deletedTable write lock
+ omMetadataManager.getTableLock(OmMetadataManagerImpl.DELETED_TABLE)
Review Comment:
This seems to be the only place we are taking the lock ? Shouldn't we be
taking the lock in delete code path as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
