smengcl commented on code in PR #4280:
URL: https://github.com/apache/ozone/pull/4280#discussion_r1120651143
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -549,6 +564,8 @@ protected void initializeOmTables(boolean addCacheMetrics)
deletedTable = this.store.getTable(DELETED_TABLE, String.class,
RepeatedOmKeyInfo.class);
checkTableStatus(deletedTable, DELETED_TABLE, addCacheMetrics);
+ // Currently, deletedTable is the only table that will need the table lock
+ tableLockMap.put(DELETED_TABLE, new ReentrantReadWriteLock(true));
Review Comment:
Basically any operation that read/write `deletedTable` needs to grab its
table lock. It does not have a strictly enforced hierarchy like
`OzoneManagerLock` does.
For the scope of this PR, only
`OmSnapshotManager#createOmSnapshotCheckpoint` uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
