adoroszlai commented on code in PR #4391:
URL: https://github.com/apache/ozone/pull/4391#discussion_r1135340787
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -757,48 +785,66 @@ private boolean moveContainer(DatanodeDetails source,
CompletableFuture<MoveManager.MoveResult> future;
try {
ContainerInfo containerInfo = containerManager.getContainer(containerID);
- future = replicationManager
- .move(containerID, source, moveSelection.getTargetNode())
- .whenComplete((result, ex) -> {
-
- metrics.incrementCurrentIterationContainerMoveMetric(result, 1);
- if (ex != null) {
- LOG.info("Container move for container {} from source {} to " +
- "target {} failed with exceptions {}",
- containerID.toString(),
+
+ ReplicationManager.ReplicationManagerConfiguration rmConf =
+ ozoneConfiguration.getObject(
+ ReplicationManager.ReplicationManagerConfiguration.class);
Review Comment:
nit: I think this should be stored in the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
