siddhantsangwan commented on PR #4391: URL: https://github.com/apache/ozone/pull/4391#issuecomment-1469625557
I noticed a subtle bug in this PR. We're only constructing `MoveManager` once when `ContainerBalancerTask` is constructed. But `ContainerBalancerTask` works in iterations and resets any collections or members that hold state. Since `MoveManager` tracks moves using ContainerID as the key in a hash map, we need to reset its state between iterations too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
