sodonnel commented on code in PR #4391:
URL: https://github.com/apache/ozone/pull/4391#discussion_r1135475416
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerConfiguration.java:
##########
@@ -93,16 +93,16 @@ public final class ContainerBalancerConfiguration {
"to exclude from balancing. For example \"1, 4, 5\" or \"1,4,5\".")
private String excludeContainers = "";
- @Config(key = "move.timeout", type = ConfigType.TIME, defaultValue = "30m",
+ @Config(key = "move.timeout", type = ConfigType.TIME, defaultValue = "60m",
Review Comment:
We can do this in another PR, but there is a timeout hard coded into
MoveManager right now. Probably we need to pass this value into MoveManager
somehow so it passes a sensible timeout to RM when scheduling the command. That
will then set the DN deadline and the pending Ops timeout.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerConfiguration.java:
##########
@@ -93,16 +93,16 @@ public final class ContainerBalancerConfiguration {
"to exclude from balancing. For example \"1, 4, 5\" or \"1,4,5\".")
private String excludeContainers = "";
- @Config(key = "move.timeout", type = ConfigType.TIME, defaultValue = "30m",
+ @Config(key = "move.timeout", type = ConfigType.TIME, defaultValue = "60m",
tags = {ConfigTag.BALANCER}, description =
"The amount of time to allow a single container to move " +
"from source to target.")
- private long moveTimeout = Duration.ofMinutes(30).toMillis();
+ private long moveTimeout = Duration.ofMinutes(60).toMillis();
@Config(key = "balancing.iteration.interval", type = ConfigType.TIME,
- defaultValue = "70m", tags = {ConfigTag.BALANCER}, description =
+ defaultValue = "130m", tags = {ConfigTag.BALANCER}, description =
Review Comment:
Should the timeout and interval not be quite close in time? If commands
timeout after 60 mins, and the interval is 130m, does that mean the balancer
will go idle for some time in between?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
