duongkame commented on code in PR #4389: URL: https://github.com/apache/ozone/pull/4389#discussion_r1141227802
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java: ########## @@ -293,6 +295,8 @@ public class OmMetadataManagerImpl implements OMMetadataManager, private Map<String, Table> tableMap = new HashMap<>(); private List<TableCacheMetrics> tableCacheMetrics = new LinkedList<>(); + private TableCache<CacheKey<String>, CacheValue<S3SecretValue>> s3SecretCache; Review Comment: I don't think the secret cache needs to be coupled with the secret store implementation. Just using the `S3ImMemoryCache` for both cases is good enough. At the end of the day, they're just im-memory cache. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
