Pochatkin commented on code in PR #4389: URL: https://github.com/apache/ozone/pull/4389#discussion_r1143787816
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/s3http/vault/auth/AuthType.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.om.s3http.vault.auth; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.ozone.om.s3http.S3SecretStoreConfigurationKeys; + +import static org.apache.hadoop.ozone.om.s3http.S3SecretStoreConfigurationKeys.APP_ROLE_ID; +import static org.apache.hadoop.ozone.om.s3http.S3SecretStoreConfigurationKeys.APP_ROLE_PATH; +import static org.apache.hadoop.ozone.om.s3http.S3SecretStoreConfigurationKeys.APP_ROLE_SECRET; +import static org.apache.hadoop.ozone.om.s3http.S3SecretStoreConfigurationKeys.AUTH_TYPE; + +/** + * Type of authentication method. + */ +public enum AuthType { + APP_ROLE("appRole"), + TOKEN("token"); + + private final String name; + + AuthType(String name) { + this.name = name; + } + + public String getName() { + return name; + } + + public static Auth fromConf(Configuration conf) { + AuthType authType = AuthType.valueOf(conf.get(AUTH_TYPE)); + switch (authType) { + case TOKEN: + String token = conf.get(S3SecretStoreConfigurationKeys.TOKEN); Review Comment: This method may be used in cases when token lifetime is infinite, of course if token renewal currently it will fail on next Vault access. I think I will create a follow-up ticket with ability to configure token provider in configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
