Pochatkin commented on code in PR #4389:
URL: https://github.com/apache/ozone/pull/4389#discussion_r1147526459
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/S3SecretManagerImpl.java:
##########
@@ -64,6 +69,10 @@ public String getSecretString(String awsAccessKey)
"awsAccessKeyId cannot be null or empty.");
LOG.trace("Get secret for awsAccessKey:{}", awsAccessKey);
+ S3SecretValue cacheValue = s3SecretCache.get(awsAccessKey);
Review Comment:
Sorry, I missunderstand your main point.
Why S3 secret cache should updating on key/bucket read/write operations?
Your suggestion is remove cache update operations from `SecretRequest` and
create a LoadingCache directly in SecretManager? Load all values on start from
storage and update cache manually on each write operation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
