duongkame commented on code in PR #4417:
URL: https://github.com/apache/ozone/pull/4417#discussion_r1147896164
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/token/ShortLivedTokenIdentifier.java:
##########
@@ -33,18 +34,22 @@ public abstract class ShortLivedTokenIdentifier extends
TokenIdentifier {
private String ownerId;
private Instant expiry;
- private String certSerialId;
+ private UUID secretKeyId;
public abstract String getService();
protected ShortLivedTokenIdentifier() {
}
- protected ShortLivedTokenIdentifier(String ownerId, Instant expiry,
- String certSerialId) {
+ protected ShortLivedTokenIdentifier(String ownerId, Instant expiry) {
this.ownerId = ownerId;
this.expiry = expiry;
- this.certSerialId = certSerialId;
+ }
+
+ protected ShortLivedTokenIdentifier(String ownerId, Instant expiry,
Review Comment:
Agree. I've removed all the constructors around secretKeys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
