duongkame commented on code in PR #4417:
URL: https://github.com/apache/ozone/pull/4417#discussion_r1147974284
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -357,9 +357,10 @@ message BlockTokenSecretProto {
required string ownerId = 1;
required string blockId = 2;
required uint64 expiryDate = 3;
- required string omCertSerialId = 4;
+ optional string omCertSerialId = 4 [deprecated=true];
repeated AccessModeProto modes = 5;
required uint64 maxLength = 6;
+ required UUID secretKeyId = 7;
Review Comment:
Thanks, it's a nice catch.
I think by adding this piece of information to block/container tokens, a
token generated by the new version of OM couldn't be verified by older DNs
anyway. This change of using symmetric keys is not backward compatible and
requires a downtime upgrade.
Yet, in terms of protobuf general guide, it makes sense to make the new
field optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
