duongkame commented on code in PR #4417:
URL: https://github.com/apache/ozone/pull/4417#discussion_r1147982438
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java:
##########
@@ -955,8 +953,8 @@ private ContainerTokenSecretManager
createContainerTokenSecretManager(
scmCertificateClient = new SCMCertificateClient(securityConfig,
certSerialNumber, SCM_ROOT_CA_COMPONENT_NAME);
}
- return new ContainerTokenSecretManager(securityConfig,
- expiryTime);
+ return new ContainerTokenSecretManager(expiryTime,
Review Comment:
I think the check you mention is in the
[DefaultCertificateClient](https://github.com/duongnguyen0/ozone/blob/77bd133e0a899adb31c106de08484acc2d482d2d/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java#L1181-L1181),
and it's independent from the implementation of `ContainerTokenSecretManager`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
