duongkame commented on PR #4417: URL: https://github.com/apache/ozone/pull/4417#issuecomment-1486260372
> @duongkame , thanks for working on this. It's really quite a big patch. Can we separate it into small ones? It's hard to find the exact piece of code line to add comments. Thanks for looking at this @ChenSammi. At the beginning I tried to deliver in smaller pieces, e.g. separate token generator and verifier, or block and container tokens... But I couldn't figure out a good way to do that because the logic parts are very coherent. E.g. the token verifier depends on the generator, block token and container token share the same root... Anyway, the number of changed files are huge because of many adapted test cases. The number of core changes are limited in the diagram in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
