umamaheswararao commented on PR #4417: URL: https://github.com/apache/ozone/pull/4417#issuecomment-1498145503
Yeah it's a large patch. Looks like it may be hard to separate as small pieces as lot of the files touched due to passing over the variables etc. Just wondering whether we can just provide implementation for some of the new classes like SecretKey*Client etc as this is in branch. That may not reduce much I guess. Please take care of avoid touching with some unrelated changes here as this patch is already big ex: [OzoneSecurityUtil.java](https://github.com/apache/ozone/pull/4417/files#diff-e529de824e59167df92980141f9267d1702153c4d8c6d44c1a87da9a2063730e) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
