duongkame commented on code in PR #4417:
URL: https://github.com/apache/ozone/pull/4417#discussion_r1149857025
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java:
##########
@@ -245,6 +247,12 @@ public DatanodeStateMachine(DatanodeDetails
datanodeDetails,
queueMetrics = DatanodeQueueMetrics.create(this);
}
+ @VisibleForTesting
+ public DatanodeStateMachine(DatanodeDetails datanodeDetails,
Review Comment:
I'm not a fan of it either but feel guilty repeating `null, null, null,
null.....` 10 times in tests. It could be easy to create such a constructor in
a test folder, but that would not be shared across maven components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
