aswinshakil commented on code in PR #4486:
URL: https://github.com/apache/ozone/pull/4486#discussion_r1151212903
##########
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/OMMetadataManager.java:
##########
@@ -544,4 +544,10 @@ String getMultipartKey(long volumeId, long bucketId,
*/
long getBucketId(String volume, String bucket) throws IOException;
+ /**
+ * Returns List<{@link BlockGroup}> for a key in the deletedTable.
+ * @param deletedKey - key to be purged from the deletedTable
+ * @return {@link BlockGroup}
+ */
+ List<BlockGroup> getBlocksForKeyDelete(String deletedKey) throws IOException;
Review Comment:
We shouldn't limit it, otherwise we don't reclaim all blocks of a particular
key. This is similar to KeyDeletingService which also only limits on number of
keys. Also `ozone.snapshot.key.deleting.limit.per.task` ensures that we have a
hard limit on the number of keys we process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
