aswinshakil commented on code in PR #4486:
URL: https://github.com/apache/ozone/pull/4486#discussion_r1152283383
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java:
##########
@@ -234,13 +238,26 @@ public BackgroundTaskResult call() throws Exception {
if (!(toReclaim.getKeyInfosCount() ==
repeatedOmKeyInfo.getOmKeyInfoList().size())) {
toReclaimList.add(toReclaim.build());
Review Comment:
It can be. But one problem is if the OM leader changes in between, it won't
have the updated snapshot's `deletedTable` if we do this in-place. As a result,
if a follower OM becomes leader it doesn't have the updated 'deletedTable` it
would repeat the same splitting of `RepeatedOmKeyInfo` which might be
redundant. Ideally the snapshot's `deletedTable` should be cleared in the next
iterations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
