smengcl commented on code in PR #4486:
URL: https://github.com/apache/ozone/pull/4486#discussion_r1151265660
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyDeletingService.java:
##########
@@ -172,24 +129,9 @@ public BackgroundTaskResult call() throws Exception {
List<BlockGroup> keyBlocksList = manager
.getPendingDeletionKeys(keyLimitPerTask);
Review Comment:
Despite the PR title, I don't see the code to make KDS aware of snapshots is
implemented yet in this PR? In order to do that, extra logic has to be added in
`OmMetadataManagerImpl#getPendingDeletionKeys()` to check whether the key
exists in the previous snapshot (in the same scope).
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyDeletingService.java:
##########
@@ -172,24 +129,9 @@ public BackgroundTaskResult call() throws Exception {
List<BlockGroup> keyBlocksList = manager
.getPendingDeletionKeys(keyLimitPerTask);
Review Comment:
Despite the PR title, I don't see the code to make KDS aware of snapshots is
implemented yet in this PR?
In order to do that, extra logic has to be added in
`OmMetadataManagerImpl#getPendingDeletionKeys()` to check whether the key
exists in the previous snapshot (in the same scope).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
