ashishkumar50 commented on code in PR #4531:
URL: https://github.com/apache/ozone/pull/4531#discussion_r1159501894
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java:
##########
@@ -444,6 +445,11 @@ private void getCacheValues() {
continue;
}
+ // Copy cache value to local copy and work on it
Review Comment:
Hi @swagle , Thanks for the review. OmDirectoryInfo and OmKeyInfo are only
objects used for accessing cache in OzoneListStatusHelper.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java:
##########
@@ -444,6 +445,11 @@ private void getCacheValues() {
continue;
}
+ // Copy cache value to local copy and work on it
+ Value copyOmInfo = ObjectUtils.clone(cacheOmInfo);
Review Comment:
Hi @kerneltime , Thanks for the review. In MinHeapIterator already read
bucket locking exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
