ashishkumar50 commented on code in PR #4531:
URL: https://github.com/apache/ozone/pull/4531#discussion_r1166392116
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -789,6 +789,36 @@ public OmKeyInfo copyObject() {
return builder.build();
}
+ /**
+ * Return a new copy of the object.
+ */
+ @Override
+ public Object clone() throws CloneNotSupportedException {
+ OmKeyInfo omKeyInfo = (OmKeyInfo) super.clone();
+
+ omKeyInfo.metadata = new HashMap<>();
+ omKeyInfo.keyLocationVersions = new ArrayList<>();
+ omKeyInfo.acls = new ArrayList<>();
+
+ keyLocationVersions.stream().filter(keyLocationVersion ->
+ keyLocationVersion != null).forEach(keyLocationVersion ->
+ omKeyInfo.keyLocationVersions.add(
+ new OmKeyLocationInfoGroup(keyLocationVersion.getVersion(),
+ keyLocationVersion.getLocationList(),
Review Comment:
Hi @errose28 thanks for the review.
We could have done shallow copy in HeapEntry#getStatus and modify just the
two fields which is required, but still cache value having same reference is
present in HeapEntry and in future if some other fields gets modified there is
still possibility of corruption by not doing deep copy to the modified field.
OmKeyLocationInfo is also deep copied as pointed out by Ritesh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
