ChenSammi commented on PR #4574: URL: https://github.com/apache/ozone/pull/4574#issuecomment-1511283341
> It's a good idea that switch other metrics from ms to `ns`. But is there a more direct way to confirm the units of a metric? Currently, if I want to confirm the units of an metric, I can only check the code to confirm Yeah, it's not easy to tell whether it's ns or ms for a time metrics in Ozone now. One solution is we use one granularity for all latency/time metrics, say ns. Another solution is like in this patch, we add the suffix "ns" or "ms" for every metrics name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
