hemantk-12 commented on code in PR #4574:
URL: https://github.com/apache/ozone/pull/4574#discussion_r1171947710
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java:
##########
@@ -191,14 +191,14 @@ public long getNumBytesCommittedCount() {
return numBytesCommittedCount.value();
}
- public MutableRate getApplyTransactionLatency() {
- return applyTransaction;
+ public MutableRate getApplyTransactionNsLatency() {
Review Comment:
nit:
```suggestion
public MutableRate getApplyTransactionLatencyNs() {
```
Ms and Ns are used as suffix in variable names but in functions it is not
consistent. Can you please change it here as well as
`recordApplyTransactionNsCompletion` to `recordApplyTransactionCompletionNs`
and `recordWriteStateMachineNsCompletion`
to`recordWriteStateMachineCompletionNs`? Similar to `incPipelineLatencyMs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
