sumitagrawl commented on code in PR #4618:
URL: https://github.com/apache/ozone/pull/4618#discussion_r1177529225
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -146,12 +146,24 @@ public class DatanodeConfiguration {
*/
@Config(key = "block.delete.queue.limit",
type = ConfigType.INT,
- defaultValue = "1440",
+ defaultValue = "5",
tags = {DATANODE},
description = "The maximum number of block delete commands queued on " +
" a datanode"
)
- private int blockDeleteQueueLimit = 60 * 24;
+ private int blockDeleteQueueLimit = 5;
Review Comment:
@sodonnel
Its assumed that SCM send delete command every 1 minute and queue is
created for 1 hour, so 60*24=1440 is configured. But SCM behavior is,
- If previous command is not completed, it will send same blocks again and
again. So its not useful to have big queue size. Normally after completion of
previous command, then next command will be new entry. So kept queue size of
"5" to avoid handling too many duplicate commands under abnormal scenario.a
- SCM sends delete block every 5 minutes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
