sumitagrawl commented on code in PR #4618:
URL: https://github.com/apache/ozone/pull/4618#discussion_r1177539933
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/StateContext.java:
##########
@@ -795,6 +800,11 @@ public SCMCommand getNextCommand() {
public void addCommand(SCMCommand command) {
lock.lock();
try {
+ if (commandQueue.size() > maxCommandQueueLimit) {
Review Comment:
@sodonnel
In earlier version, delete block was executed synchronously causing many
commands accumulated. But this is resolved in later version.
The probability of command queue getting accumulated is rare, as commands
takings lot of time is handover to sub-queue, and few commands only executed
synchronously.
This is just a upper cap for all command queue to avoid any such issue if
happens due to some bug or abnormal scenario, as good practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
