sodonnel commented on code in PR #4618:
URL: https://github.com/apache/ozone/pull/4618#discussion_r1178029337
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationSupervisor.java:
##########
@@ -96,13 +100,19 @@ public ReplicationSupervisor(
new ThreadFactoryBuilder().setDaemon(true)
.setNameFormat("ContainerReplicationThread-%d")
.build()),
- clock);
+ clock, maxQueueSize);
}
/**
* Queue an asynchronous download of the given container.
*/
public void addTask(AbstractReplicationTask task) {
+ if (getQueueSize() >= maxQueueSize) {
+ LOG.warn("Replication supervisor receive command for container {} "
Review Comment:
Suggest rewording this log and including the task class in it, eg:
```
LOG.warn(Ignored a {} command for container {} in the Replication Supervisor
as the queue has reached the max size of {}.,
task.class, task.getContainerId(), maxQueueSize());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
