sumitagrawl commented on PR #4683: URL: https://github.com/apache/ozone/pull/4683#issuecomment-1542309955
> Thx @sumitagrawl for the work. The idea of adding a timer to timely trigger the Ratis snapshot mostly looks fine to me. Left a few comments. > > Besides, we need to reset txFlushPending in **SCMHADBTransactionBufferImpl#init**. When a snapshot is loaded and reinited, the txFlushPending should be reset also. @Xushaohong Its updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
