Xushaohong commented on code in PR #4683:
URL: https://github.com/apache/ozone/pull/4683#discussion_r1196019799
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java:
##########
@@ -562,7 +562,7 @@ public final class ScmConfigKeys {
1000L;
public static final String OZONE_SCM_HA_RATIS_SNAPSHOT_GAP
- = "raft.server.snapshot.creation.gap";
+ = "ozone.scm.ha.ratis.server.snapshot.creation.gap";
Review Comment:
Hi @sumitagrawl
Actually, I mean these two:
ScmConfigKeys.**OZONE_SCM_HA_RATIS_SNAPSHOT_THRESHOLD** and
**OZONE_SCM_HA_RATIS_SNAPSHOT_GAP**.
They are both SCM side conf, but their similar names could be confusing for
those not too familiar.
It might be better to add some comments to tell the difference or rename
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
