Xushaohong commented on code in PR #4683:
URL: https://github.com/apache/ozone/pull/4683#discussion_r1195162045
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java:
##########
@@ -562,7 +562,7 @@ public final class ScmConfigKeys {
1000L;
public static final String OZONE_SCM_HA_RATIS_SNAPSHOT_GAP
- = "raft.server.snapshot.creation.gap";
+ = "ozone.scm.ha.ratis.server.snapshot.creation.gap";
Review Comment:
Could you refine the name and add some comments to help with the
comprehension for the other reader? It might be confusing with the
AutoTriggerThreshold as it is only used when RATIS ```takeSnapshotAsync``` by
manual.
How about ozone.scm.ha.ratis.snapshot.creation.auto.threshold and
ozone.scm.ha.ratis.snapshot.creation.manual.gap respectively?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
