smengcl commented on code in PR #4819:
URL: https://github.com/apache/ozone/pull/4819#discussion_r1232902683
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1799,10 +1800,22 @@ message SnapshotDiffResponse {
DONE = 3;
REJECTED = 4;
FAILED = 5;
+ CANCELED = 6;
}
+
+ enum CancelStatusProto {
+ JOB_NOT_CANCELED = 1;
Review Comment:
Let's use double-l
```suggestion
JOB_NOT_CANCELLED = 1;
```
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1799,10 +1800,22 @@ message SnapshotDiffResponse {
DONE = 3;
REJECTED = 4;
FAILED = 5;
+ CANCELED = 6;
}
+
+ enum CancelStatusProto {
+ JOB_NOT_CANCELED = 1;
+ NEW_JOB = 2;
+ JOB_DONE = 3;
+ INVALID_STATUS_TRANSITION = 4;
+ JOB_ALREADY_CANCELED = 5;
Review Comment:
nit
```suggestion
JOB_ALREADY_CANCELLED = 5;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
