smengcl commented on code in PR #4819:
URL: https://github.com/apache/ozone/pull/4819#discussion_r1232926538
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1799,10 +1800,22 @@ message SnapshotDiffResponse {
DONE = 3;
REJECTED = 4;
FAILED = 5;
+ CANCELED = 6;
}
+
+ enum CancelStatusProto {
Review Comment:
IMO this is more of just a `Result` to the one-time client request rather
than a `Status` for the diff job like `JobStatusProto`.
```suggestion
enum JobCancelResultProto {
```
Another example:
https://github.com/apache/ozone/blob/bdd26eeca9fe7adfd87a4ee1e0acfd84d6148c57/hadoop-hdds/interface-server/src/main/proto/ScmServerProtocol.proto#L182-L199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
