smengcl commented on code in PR #4819:
URL: https://github.com/apache/ozone/pull/4819#discussion_r1232928420
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/snapshot/SnapshotDiffResponse.java:
##########
@@ -67,18 +112,28 @@ public long getWaitTimeInMs() {
return waitTimeInMs;
}
+ public CancelStatus getCancelStatus() {
+ return cancelStatus;
+ }
+
@Override
public String toString() {
StringBuilder str = new StringBuilder();
- if (jobStatus == JobStatus.DONE) {
- str.append(snapshotDiffReport.toString());
+ if (cancelStatus == CancelStatus.JOB_NOT_CANCELED ||
+ cancelStatus == CancelStatus.CANCEL_SUCCESS) {
+ if (jobStatus == JobStatus.DONE) {
+ str.append(snapshotDiffReport.toString());
+ } else {
+ str.append("Snapshot diff job is ");
+ str.append(jobStatus);
+ str.append("\n");
Review Comment:
nit
```suggestion
str.append(". ");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
